Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Frameless BrowserView.setAutoResize() is broken in v30.0.1 #42003

Closed
3 tasks done
MaksimDedov opened this issue Apr 30, 2024 · 0 comments · Fixed by #42056
Closed
3 tasks done

[Bug]: Frameless BrowserView.setAutoResize() is broken in v30.0.1 #42003

MaksimDedov opened this issue Apr 30, 2024 · 0 comments · Fixed by #42056
Assignees
Labels
30-x-y 31-x-y bug 🪲 bug/regression ↩️ A new version of Electron broke something component/BrowserView component/WebContentsView has-repro-gist Issue can be reproduced with code at https://gist.github.com/ status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@MaksimDedov
Copy link

MaksimDedov commented Apr 30, 2024

Preflight Checklist

Electron Version

30.0.1

What operating system are you using?

Windows

Operating System Version

Windows 11

What arch are you using?

x64

Last Known Working Electron version

29.3.1

Expected Behavior

The BrowserView.setAutoResize function should automatically change the content size on the Main window resize.

Actual Behavior

While resizing Electron throws the next exception from the autoResize function:
image

Testcase Gist URL

https://github.com/MaksimDedov/test-electron

Additional Information

There is no autoResize feature for the WebContentsView. So I had to do a workaround like subscribe on the MainWindow resize event and send bounds for the view. It seems like a workable solution but with less performance I guess.

@VerteDinde VerteDinde added has-repro-gist Issue can be reproduced with code at https://gist.github.com/ component/WebContentsView 30-x-y labels Apr 30, 2024
@dsanders11 dsanders11 added bug/regression ↩️ A new version of Electron broke something component/BrowserView labels May 6, 2024
@codebytere codebytere added the status/confirmed A maintainer reproduced the bug or agreed with the feature label May 6, 2024
@codebytere codebytere self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
30-x-y 31-x-y bug 🪲 bug/regression ↩️ A new version of Electron broke something component/BrowserView component/WebContentsView has-repro-gist Issue can be reproduced with code at https://gist.github.com/ status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
Status: 👍 Does Not Block Stable
Status: 👍 Does Not Block Stable
Development

Successfully merging a pull request may close this issue.

5 participants
@codebytere @VerteDinde @dsanders11 @MaksimDedov and others