Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is AppUpdater its own class? #3571

Open
aolsenjazz opened this issue Dec 30, 2023 · 0 comments
Open

Why is AppUpdater its own class? #3571

aolsenjazz opened this issue Dec 30, 2023 · 0 comments
Labels

Comments

@aolsenjazz
Copy link
Contributor

Summary

autoUpdater configuration is done inside of its own class in main.ts. I haven't seen anything in electron-updater docs that suggest this pattern is necessary or normal:

class AppUpdater {
  constructor() {
    log.transports.file.level = 'info';
    autoUpdater.logger = log;
    autoUpdater.checkForUpdatesAndNotify();
  }
}

Happy to be wrong here, but the actual autoUpdater configuration ought to be moved to where new AppUpdater() is, or put inside of it's own function block. Will open a PR to do this - lmk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant