-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solution
property to Spaces
#183559
Comments
Pinging @elastic/kibana-security (Team:Security) |
@azasypkin do you have a preference/recommendation for how we control whether or not the |
Thanks for the ping. Yeah, I think having a deployment-type-specific configuration property (via |
@azasypkin @legrego I see that we don't register create/update/delete routes for spaces in serverless. |
@elena-shostak we will enable these routes for serverless as soon as the customer roles work is completed. cc @jeramysoucy |
The definition of a Space should be updated to include a
solution
property.This property should only be defined for the stateful offering. It is not applicable to serverless.
Within a stateful deployment, this property is required for all new Spaces, and optional for all existing spaces. This enforcement can happen in code and should not require a Saved Objects migration.
Valid values for the
solution
property:undefined
(to accommodate all existing spaces)'security'
'observability'
'search'
'classic'
Requirements
solution
property.1a) This property is forbidden for serverless projects.
1b) This property is required to be defined for stateful deployments (key and value CANNOT be
undefined
). To facilitate iterative development, we may want to ship this as an optional property until all of the workstreams are complete, and create a followup PR which changes this from optional to required.solution
property.2a) This property is forbidden for serverless projects.
2b) This property is optional for stateful deployments (key and value CAN be
undefined
). To facilitate iterative development, we may want to ship this as an optional property until all of the workstreams are complete, and create a followup PR which changes this from optional to required.2b1) When the
solution
property is provided, the value cannot beundefined
. This prevents a space from unsetting their solution.2b2) When the
solution
property is not provided, the value should not be modified.solution
property of the requested space for stateful deployments. The property should not be returned for serverless projects.solution
property for all spaces in the payload. The property should not be returned for serverless projects.Important
These public APIs are powered by the SpacesClient, which is exposed by the
spaces
plugin contract. We should make every effort to enforce these rules within theSpacesClient
so that other plugins aren't able to bypass these restrictions.The text was updated successfully, but these errors were encountered: