Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddables] Duplicate, Copy to dashboard, and Save as new dashboard actions do not include references #183551

Closed
nickpeihl opened this issue May 15, 2024 · 1 comment · Fixed by #183778
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nickpeihl
Copy link
Member

The Duplicate and Copy to Dashboard panel actions drop any references for React embeddables. The serialized state in React embeddables that reference other saved objects such as Links, Maps, and Visualize includes a references array, but only the rawState is passed to the Dashboard container input.

The serializedState in the duplicateReactEmbeddableInput only passes the rawState to the explicit input. So duplicated panels will not see their references.

Here's an example from the React map embeddable PR.

maps-duplicate.mp4

And here's an example from the React Links embeddable PR.

links-duplicate.mp4

This appears to also be a problem with the Copy to New Dashboard and Save as New Dashboard.

Image embeddable does not appear to be affected by this issue.

@nickpeihl nickpeihl added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas project:embeddableRebuild labels May 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nickpeihl nickpeihl self-assigned this May 15, 2024
@ThomThomson ThomThomson added loe:medium Medium Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
3 participants