Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulkIndexer WaitGroup delta is added after workers are launched #796

Open
Jakub-Kapusta opened this issue Feb 5, 2024 · 0 comments
Open

Comments

@Jakub-Kapusta
Copy link

w.run()
bi.workers = append(bi.workers, &w)
}
bi.wg.Add(bi.config.NumWorkers)

The wg Delta should generally be added before relevant go-routines are launched.
Reference: https://pkg.go.dev/sync#WaitGroup.Add

This might not be a big issue in this case, but it strays from best practices.
Also, it creates a small window where a worker could call Done() before the call to Add(), which is not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant