You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This might not be a big issue in this case, but it strays from best practices.
Also, it creates a small window where a worker could call Done() before the call to Add(), which is not ideal.
The text was updated successfully, but these errors were encountered:
go-elasticsearch/esutil/bulk_indexer.go
Lines 380 to 383 in a58e89f
The
wg
Delta should generally be added before relevant go-routines are launched.Reference: https://pkg.go.dev/sync#WaitGroup.Add
This might not be a big issue in this case, but it strays from best practices.
Also, it creates a small window where a worker could call
Done()
before the call toAdd()
, which is not ideal.The text was updated successfully, but these errors were encountered: