AssertionError at TopScoreDocCollector.java:75

[DaveCTurner]

CI Link

https://gradle-enterprise.elastic.co/s/fo7aqcomz2icg

Repro line

N/A

Does it reproduce?

Didn't try

Applicable branches

main

Failure history

N/A

Failure excerpt

Node crashed with the following in its logs:

java.lang.AssertionError
	at [email protected]/org.apache.lucene.search.TopScoreDocCollector$SimpleTopScoreDocCollector$1.collect(TopScoreDocCollector.java:75)
	at [email protected]/org.apache.lucene.search.Weight$DefaultBulkScorer.scoreRange(Weight.java:277)
	at [email protected]/org.apache.lucene.search.Weight$DefaultBulkScorer.score(Weight.java:236)
	at [email protected]/org.elasticsearch.search.internal.CancellableBulkScorer.score(CancellableBulkScorer.java:45)
	at [email protected]/org.apache.lucene.search.BulkScorer.score(BulkScorer.java:38)
	at [email protected]/org.elasticsearch.search.internal.ContextIndexSearcher.searchLeaf(ContextIndexSearcher.java:431)
	at [email protected]/org.elasticsearch.search.internal.ContextIndexSearcher.search(ContextIndexSearcher.java:360)
	at [email protected]/org.elasticsearch.search.internal.ContextIndexSearcher.lambda$search$4(ContextIndexSearcher.java:345)
	at [email protected]/org.apache.lucene.search.TaskExecutor$TaskGroup.lambda$createTask$0(TaskExecutor.java:117)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at [email protected]/org.elasticsearch.common.util.concurrent.TimedRunnable.doRun(TimedRunnable.java:33)
	at [email protected]/org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:984)
	at [email protected]/org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:26)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

java.lang.AssertionError
	at [email protected]/org.apache.lucene.search.TopScoreDocCollector$SimpleTopScoreDocCollector$1.collect(TopScoreDocCollector.java:75)
	at [email protected]/org.apache.lucene.search.Weight$DefaultBulkScorer.scoreRange(Weight.java:277)
	at [email protected]/org.apache.lucene.search.Weight$DefaultBulkScorer.score(Weight.java:236)
	at [email protected]/org.elasticsearch.search.internal.CancellableBulkScorer.score(CancellableBulkScorer.java:45)
	at [email protected]/org.apache.lucene.search.BulkScorer.score(BulkScorer.java:38)
	at [email protected]/org.elasticsearch.search.internal.ContextIndexSearcher.searchLeaf(ContextIndexSearcher.java:431)
	at [email protected]/org.elasticsearch.search.internal.ContextIndexSearcher.search(ContextIndexSearcher.java:360)
	at [email protected]/org.elasticsearch.search.internal.ContextIndexSearcher.lambda$search$4(ContextIndexSearcher.java:345)
	at [email protected]/org.apache.lucene.search.TaskExecutor$TaskGroup.lambda$createTask$0(TaskExecutor.java:117)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at [email protected]/org.elasticsearch.common.util.concurrent.TimedRunnable.doRun(TimedRunnable.java:33)
	at [email protected]/org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:984)
	at [email protected]/org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:26)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

[elasticsearchmachine]

Pinging @elastic/es-search (Team:Search)

[benwtrent]

@DaveCTurner did the PR build have: e352345 in it?

[DaveCTurner]

Yes. The Source link (bottom right of the below screenshot) links to https://github.com/DaveCTurner/elasticsearch/commits/0810cada602842398b2c13f12dc79240382dfa04/ which does indeed include that commit in its ancestry.

[benwtrent]

OK, this is weird. Need to dig further. The failure log: https://es-delivery-stats.elastic.dev/app/r/s/3AZWr

The first failure is from Apr 17, 2024 @ 07:59:55.955 from commit: https://github.com/elastic/elasticsearch/commits/2f9e753463909f820493fd191ecc8f8bffb30b29/

The negative score assertion is still tripping. It SEEMS to be due to negative scores in knn, but with: e352345

I don't see how its possible :(.

[benwtrent]

Ah, 🤦 our format only changes merges. These failures should be fixed by: apache/lucene#13356

[benwtrent]

This should be fixed with Lucene update.