-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flamegraph renders incorrectly on successive renders with different data #1766
Comments
Thanks for the detailed report! We're looking into it. In the meantime, to avoid being blocked, would a fresh instantiation of the chart work? Ie. it gets a new key, so the old chart and its resources are removed from the DOM tree and a fresh one gets inserted |
@monfera I'm adding a |
referencing original issue: https://github.com/elastic/prodfiler/issues/2460 |
Closing as a workaround is already used. Please reopen in case you need an elastic-charts side fix |
(copied from @jbcrail's issue in a private repo
Describe the bug
When the time range is updated for a flamegraph, we fetch the respective data; then the flamegraph will re-render without a page refresh. In the common case where the data before and after are different, then the flamegraph will render incorrectly (text will be offset from the expected rectangle bounds, colors will not applied to the rectangles, etc). At least in Firefox, we see an error like this:
What's interesting is that the left number (15054) represents the length of the position array before the time range was updated, whereas 12822 is the array length after fetching.
To Reproduce
Steps to reproduce the behavior:
Flamegraphs
sectionSee these screenshots that reproduce the behavior:
Expected behavior
The flamegraph should always rendering correctly when the time range is updated. No WebGL warnings should be seen in the browser console.
Additional context
I created a sample test case from the existing storybook story to demonstrate the issue. I have two different columnar datasets and the example toggles between the datasets every 10 seconds.
The text was updated successfully, but these errors were encountered: