Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pull request use CI caches #1114

Open
LukasKalbertodt opened this issue Feb 21, 2024 · 0 comments
Open

Make pull request use CI caches #1114

LukasKalbertodt opened this issue Feb 21, 2024 · 0 comments
Labels
area:ci Continuous Integration kind:improvement priority:low Low priority

Comments

@LukasKalbertodt
Copy link
Member

Unfortunately, GitHub isolates caches by branch. With the newest CI rework, the first run of new PRs will always have a cache miss right now, causing it to build everything from scratch. That's annoying. PR builds can use caches created by the base or default branch (in our case usually the same). So the accepted workaround is that the default branch will run a job just to build a cache for all PRs.

This is not trivial to do with our setup. I'm not yet sure how one would best approach it.

Context: https://github.com/orgs/community/discussions/27059
@LukasKalbertodt LukasKalbertodt added area:ci Continuous Integration kind:improvement priority:low Low priority labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:ci Continuous Integration kind:improvement priority:low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LukasKalbertodt