Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to the report file of Checker.YosysSynthChecks #480

Open
kareefardi opened this issue May 23, 2024 · 3 comments
Open

Point to the report file of Checker.YosysSynthChecks #480

kareefardi opened this issue May 23, 2024 · 3 comments

Comments

@kareefardi
Copy link
Collaborator

Description

Checker.YosysSynthChecks reports errors on synthesis__check_error__count. However, there is nothing pointing towards the errors themselves and where are they located.

Proposal

Point to the report file relating to the error.

@donn
Copy link
Member

donn commented May 23, 2024

I don't think this will work given the cardinal rule of OpenLane 2 which is "steps should not be looking in other step's folders on their own"

@kareefardi
Copy link
Collaborator Author

It isn't a requirement that it point to the exact file. The current solution gives no indication to even where to look for checks errors except that both are called yosys. Some renames to the report file path would be a better start rather than what we have.

@KelvinChung2000
Copy link

Such a change will be helpful. Also, the error message should also indicate a warning (e.g., a wire is used but has no driver), which is also classified as an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants