Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transports #2

Open
larshp opened this issue Mar 3, 2017 · 9 comments
Open

transports #2

larshp opened this issue Mar 3, 2017 · 9 comments

Comments

@larshp
Copy link

larshp commented Mar 3, 2017

btw, I have a planned feature: abapGit/abapGit#263

which would need to detect when something like #1 happens

@eduardocopat
Copy link
Owner

eduardocopat commented Mar 12, 2017

@larshp I was thinking of automating this.

Do you think it would be possible to call abapGit dynamically and generate a .zip of the transport in the background?

Looking at lcl_transport and lcl_zip, I see some possibilities.

The next step would be to send to the zip to a Continuous Integration pipeline

@larshp
Copy link
Author

larshp commented Mar 12, 2017

yes, it is possible to automate, take a look at https://gist.github.com/larshp/9137612a0b758dfc43c6d4e9200a1bc7 and https://gist.github.com/larshp/5ab1c0325b1f3068eed77b6220311108 on how to hook into the abapGit functions

How about having it automatically create branches for each transport like abapGit/abapGit#263, is it not possible for you to use online projects?

Note that the zip of the transport only contains the objects changed, which might be okay for doing reviews. However linting/unit testing requires all the other objects used in the code

@eduardocopat
Copy link
Owner

@larshp Thanks as always!

I thought if this couldn't be a feature on abapGit "Transport to branch".

But, maybe this is, "scope creep" into abapGit, could be something external.

As a first approach, I'd worry only about the code review, later the linting/testing.

@larshp
Copy link
Author

larshp commented Mar 12, 2017

I also need the "Transport to branch" feature for some stuff I'm planning, and would like it to happen automatically for online repos

@eduardocopat
Copy link
Owner

eduardocopat commented Mar 12, 2017

I'll give it a try this week then, I've been busy with other stuff and could contribute to abapGit lately... Although I always read issues and pull requests

@giovannidegani
Copy link

Not sure I understand the why need of the ZIP file. I was thinking more like dynamically create the branch in Github ( Or TFS in my case ) and commit the stuff to it directly, then and branch hooks could trigger CI.

@larshp
Copy link
Author

larshp commented Mar 15, 2017

@tiefox yeah, me too. But I think Eduardo just want to test it with zips first to see how it works out

@eduardocopat
Copy link
Owner

@tiefox Yeah, that is also possible. I used the transport to zip feature because I was envisioning offline projects.

@eduardocopat
Copy link
Owner

Anyway, after abapGit/abapGit#263 is done, I'll update these slides also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants