Blank EditorConfig still forces tab width to 4 and spaces to 2

[JustinGrote]

Please fill-in this template.

• I have a question that is specific to this extension; thus, inappropriate for the main EditorConfig issue tracker.
• I tried running code --disable-extensions and the issue did NOT present itself.

Issue

If I have no editorconfig, and I have the following in my user settings.json

{
    "editor.tabSize": 2
}

then any tab-formatted file I open will reset the tab size to 4 and format using spaces

If I disable the extension and reopen the file, it behaves as expected.

I've tried this with detect indentation on and off, no difference.

If I create a .editorconfig file with indent_size line, it now behaves as expected. So there appears to be an issue with a blank config where something gets initialized with a bad default value.

[STOWouters]

I encountered the same issue after the VSCode November 2022 update.

Downgrading VSCode back to the October 2022 version (1.73.1) fixed the issue. Apparently, there have been some changes in the indent and tab size settings in VSCode

Related issues:

• Separate tab size and indent size microsoft/vscode#42740
• bug: tabSize affects indentation microsoft/vscode#10339
• Add support for mixed tab/spaces indentation microsoft/vscode#5394
• Auto indent: Allow to indent with spaces but with different size from tabSize microsoft/vscode#135058

[mazeneko]

I have the same problem.

vscode has been updated to separate tabSize and indentSize,
but editorconfig-vscode applies the indent_size option in .editorconfig only to vscode's tabSize,
and indentSize is This seems to be due to the fact that it has not been changed.

In the actual code, only the tabSize is generated here,

editorconfig-vscode/src/api.ts

Lines 160 to 172 in b86ebd4

	return {
	...(config.indent_style === 'tab' ||
	config.indent_size === 'tab' ||
	config.indent_style === 'space'
	? {
	insertSpaces: config.indent_style === 'space',
	}
	: {}),
	tabSize:
	resolved.tabSize && resolved.tabSize >= 0
	? resolved.tabSize
	: defaults.tabSize,
	}

and the vscode setting is changed here.

editorconfig-vscode/src/api.ts

Line 54 in b86ebd4

editor.options = newOptions

Also, I added the indentSize property in the debugger on this line and run it, and it was set as expected.

However, there is no indentSize in the TextEditorOptions type to actually change the code.

[huyz]

See #358 for WIP fix