Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional definition of b:editorconfig_applied for external cores #193

Open
cxw42 opened this issue Jun 20, 2022 · 1 comment
Open
Labels

Comments

@cxw42
Copy link
Member

cxw42 commented Jun 20, 2022

After f305bc7 (#142), we have:

       if s:UseConfigFiles_VimCore() == 0
            let b:editorconfig_applied = 1
        endif
    elseif s:editorconfig_core_mode ==? 'external_command'
        call s:UseConfigFiles_ExternalCommand()
        let b:editorconfig_applied = 1

I believe that should be

       if s:UseConfigFiles_VimCore() == 0
            let b:editorconfig_applied = 1
        endif
    elseif s:editorconfig_core_mode ==? 'external_command'
        if s:UseConfigFiles_ExternalCommand() == 0   " <====
          let b:editorconfig_applied = 1
        endif   " <====

plus changes to s:UseConfigFiles_ExternalCommand() to return nonzero on shell-exit != 0.

CC @dbarnett

@cxw42 cxw42 added the Bug label Jun 20, 2022
@cxw42 cxw42 changed the title Fix conditional definitiion of b:editorconfig_applied for external cores Fix conditional definition of b:editorconfig_applied for external cores Jun 20, 2022
@dbarnett
Copy link
Contributor

Thanks for the heads up! Looks reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants