Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magit views don't respect editorconfig. #288

Open
YellowOnion opened this issue Jan 17, 2023 · 2 comments
Open

Magit views don't respect editorconfig. #288

YellowOnion opened this issue Jan 17, 2023 · 2 comments

Comments

@YellowOnion
Copy link

I've opened up a discussion on the magit discussion board

Perhaps they need to expose some apis so you can get the right hints to apply the correct settings in the diff / revision view.

The commit view looks easier as you can just glob against the git "magic" i.e. .~master~ in the buffer name (if that's how it works)

@jcs090218
Copy link
Contributor

Hmmm... I don't think this is editorconfig's issue since the diff view should have the indentation display correctly, isn't it? I'm reading the codebase now, but I don't think editorconfig should be responsible for the diff mode. 😕

@10sr
Copy link
Member

10sr commented Apr 28, 2023

Basically editorconfig works for files, and the diff view is not related to a file. So, at least, currently this is an expected behavior...

One possible idea is implementing a function that gets indent values from .editorconfig and sets them to diff-mode, and adding that to diff-mode-hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants