Raise error when computed global is set or reset. #7374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwpark
force-pushed
the
set-computed-global
branch
from
ea520dd
to
e8b0c54
Compare
msullivan
reviewed
May 22, 2024
| if isinstance(expr, (qlast.ConfigSet, qlast.ConfigReset)): | ||
| if glob.get_expr(ctx.env.schema): | ||
| raise errors.ConfigurationError( | ||
| f"global '{glob_name}' is computed from an expression and " |
There was a problem hiding this comment.
I'd probably just say "computed global 'whatever' may not be modified" or some such
msullivan
approved these changes
May 22, 2024
|
@msullivan I saw the issue mentioned that. With these changes, it seems that setting the global silently deletes it from the state. |
I'm not sure what you mean by that |
msullivan
approved these changes
May 22, 2024
dnwpark
force-pushed
the
set-computed-global
branch
from
ccd4fbf
to
022a181
Compare
|
Also added a test to the python client here: edgedb/edgedb-python#494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
set global foo := false;, attempting to runset global lol := false;produces the following error:close #7368