Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow setting a global if it was declared with a computable expression #7368

Closed
aljazerzen opened this issue May 20, 2024 · 1 comment · Fixed by #7374
Closed

Don't allow setting a global if it was declared with a computable expression #7368

aljazerzen opened this issue May 20, 2024 · 1 comment · Fixed by #7374
Assignees

Comments

@aljazerzen
Copy link
Contributor

Schema:

module default {
    global test := 'hello';
}
> set global test := 'world'; <--- this should error out, but it does not
OK

> select global test;
{'hello'}    <--- because this is confusing
@msullivan
Copy link
Member

We'll also want to test that it fails when trying to set it directly from a client, also. That might be either more or less gnarly.

See test_edgeql_globals_composite for a test where we set globals using the protocol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants