Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite doesn't parallelize as well as it should #7329

Open
msullivan opened this issue May 9, 2024 · 2 comments
Open

Test suite doesn't parallelize as well as it should #7329

msullivan opened this issue May 9, 2024 · 2 comments

Comments

@msullivan
Copy link
Member

Some of this is probably because CREATE DATA BRANCH is serialized; we could consider loosening that restriction a bit (based on size of conn pool?) or bringing back the old testmode only database clone that uses postgres template databases.

Some might be because we have too much stuff with parallelization restrictions, and should tidy it up, and I think our algorithms about allocating those are questionable.

Some might just be inefficiency in the scheduler? I'm not sure.
@msullivan
Copy link
Member Author

Getting rid of the branch semaphore takes me from 13.5m for the tests (not counting a minute for cached bootstrap) to 11.5.

msullivan added a commit that referenced this issue Jun 20, 2024
@msullivan
Add an internal-only TEMPLATE BRANCH that directly uses sql templates
e3b97ab 
The test suite used to rely on this for cloning databases, and switching
away caused some big slowdowns. Both because this method is somewhat faster
but more because the new method only allows one branch at a time to avoid
going overbudget on connections.

Progress on #7329.
On my machine this speed up edb test from 13:49 to 11:20.
@msullivan msullivan mentioned this issue Jun 20, 2024
Merged
msullivan added a commit that referenced this issue Jun 20, 2024
@msullivan
Add an internal-only TEMPLATE BRANCH that directly uses sql templates (…
16193df 
…#7477)

The test suite used to rely on this for cloning databases, and switching
away caused some big slowdowns. Both because this method is somewhat faster
but more because the new method only allows one branch at a time to avoid
going overbudget on connections.

Progress on #7329.
On my machine this speed up edb test from 13:49 to 11:20.
@msullivan
Copy link
Member Author

The CREATE DATA BRANCH problem is fixed but I think there still might be some issues here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msullivan