-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve validators to ensure more TCK test coverage #81
Labels
Comments
looks interesting. would like to work on it. |
@pmlopes could you please give me some comments on the PR? many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we skip about 300 tests from the TCK:
https://github.com/eclipse-vertx/vertx-json-schema/blob/master/src/test/resources/unsupported-tck-tests.properties
This is a general purpose issue to track pull request to address the issues. The issues should be considered "good first issue" kind of tasks.
To address an unsupported test, first one needs to understand the test, for example:
shows that the code we have here:
vertx-json-schema/src/main/java/io/vertx/json/schema/impl/Format.java
Lines 197 to 202 in cce9a61
Is actually not fully correct. It does validate that the input follows the right notation but doesn't validate edge cases like mentioned in the case above.
To fix this, that method must be refactored to perform the complete validation, not just the format string.
While this issue can be solved without much thinking, extra attention should be used to verify the performance/thread safety of the implementation as the code can be on the "hot" path of the execution of a vert.x application.
We will be availabe to support new contributors to work on these issues!
The text was updated successfully, but these errors were encountered: