Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate migration from XML to xml2 #59

Open
maelle opened this issue Mar 2, 2022 · 10 comments
Open

Evaluate migration from XML to xml2 #59

maelle opened this issue Mar 2, 2022 · 10 comments

Comments

@maelle
Copy link

maelle commented Mar 2, 2022

Just curious why {XML} is used rather than {xml2}? {XML} is no longer maintained.

@eblondel
Copy link
Owner

eblondel commented Mar 2, 2022

That's not right: XML is maintained but by CRAN team and not anymore by the original author. Given the number of dependencies historically using XML, I doubt XML will be no longer maintained in time.

XML is used for various reasons, starting with the fact the packages I build (including ows4R and related such as geometa) needed XML at that time where xml2 was very limited. I had performed already some assessment in time whether it would be beneficial to move to xml2, and so far the answer is no. Writing complex XML (like with ISO/OGC schemas) is not an easy task in R and XML fulfills all needs. In addition, assuming that we could move to xml2, refactoring would have a significant cost ensuring everything is working as it is currently with {XML}. The question to move to xml2 might come back on the table in case CRAN team decides to kill {XML} package some day, which I doubt seriously. If they decide not to maintain it anymore and make it an orphaned, I will probably candidate to take over its maintenance.

@eblondel
Copy link
Owner

eblondel commented Mar 2, 2022

PS: I will open a gitter or a github discussion soon for ows4R, to move all discussions aspects there, so we keep tickets for bug/enhancements :-)

@eblondel
Copy link
Owner

eblondel commented Mar 2, 2022

https://gitter.im/ows4R/community

@eblondel eblondel closed this as completed Mar 2, 2022
@maelle
Copy link
Author

maelle commented Mar 2, 2022

Thank you!!

@maelle
Copy link
Author

maelle commented May 2, 2023

@eblondel for info, you might find that thread interesting: RConsortium/r-repositories-wg#26

@eblondel
Copy link
Owner

eblondel commented May 2, 2023

Thanks @maelle for this
at that time when I had look at xml2, I didn't find a way to write XML files with it. Packages such as ows4R, geometa and others I've been writing rely on XML decoding and encoding. Probably xml2 is capable to do writing of xml, and hopefulle XML validation vs. XML schemas which is a key feature done with XML package. From my side, I'm definitely in favor of a migration to xml2, but this requires assessment to make sure all XML capabilities are covered, without any side effect or loss of functionality. Referring to geometa, which metadata model is extensively used in ows4R (through CSW management of metadata), it's the most complex XML handling I did in packages.

Probably I will start doing this XML-->xml2 assessment, and transition test with other simpler models like those managed in atom4R, geosapi or geonapi.

@eblondel eblondel reopened this May 2, 2023
@eblondel
Copy link
Owner

eblondel commented May 2, 2023

Btw, i reopen this issue, let's keep it open, until I start tackling it.

@eblondel eblondel changed the title XML vs xml2? Assess migration from XML to xml2 May 2, 2023
@eblondel eblondel changed the title Assess migration from XML to xml2 Evaluate migration from XML to xml2 May 2, 2023
@maelle
Copy link
Author

maelle commented May 2, 2023

Yes xml2 can write files. Regarding schema validation, I've never done that but I see https://xml2.r-lib.org/reference/xml_validate.html

Thank you and good luck with the assessment/transition!

@eblondel
Copy link
Owner

eblondel commented Feb 28, 2024

The migration from XML to xml2 is ongoing as cross-cutting activity between several packages. For now it has been applied on rather simple XML implementations (Done with geosapi in its latest release) and is analyzed in others with increasing XML schemas complexity, starting with [atom4R)(https://github.com/eblondel/atom4R). Progressively I hope to be able to tackle geometa and ows4R

@maelle
Copy link
Author

maelle commented Feb 29, 2024

Thank you for this work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants