Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script fails to run but action succeeds #115

Open
furacas opened this issue Feb 13, 2023 · 10 comments
Open

Script fails to run but action succeeds #115

furacas opened this issue Feb 13, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@furacas
Copy link

furacas commented Feb 13, 2023

I have some scripts that may fail to run, but the Action always succeeds whether it fails or not, I can't get the message that the Action's run failed

@gigsta12
Copy link

@furacas Are you providing the full path to the script you are wanting to run? Alternatively you could also cd to the directory within the SCRIPT_AFTER and then call the script.

@furacas
Copy link
Author

furacas commented Feb 20, 2023

@furacas Are you providing the full path to the script you are wanting to run? Alternatively you could also cd to the directory within the SCRIPT_AFTER and then call the script.

sure, What I want to express is that the script fails to run, but the Github Action runs successfully. I expect that when the script fails to run, Github Action prompts failure

@easingthemes
Copy link
Owner

Currently main action task is rsync deployment.
SSH scripts before/after are only logging results or error.
I can add additional param / env var to control this behaviour.
Default will still be just logging.

@easingthemes easingthemes added the enhancement New feature or request label Feb 20, 2023
@domstubbs
Copy link

That would be really handy – we’re running migrations and reloading services in our post-deploy script, so any failures there are serious and we need to know about them. The individual action logs aren’t likely to be reviewed if they’re being logged as successful.

Thanks for the action, it’s a real timesaver.

@durch
Copy link

durch commented Mar 1, 2023

Tacking on to this, we're seeing succesful taks even when rsync fails, logs below:

❌ [Rsync] error: 
Error: rsync exited with code 23
    at ChildProcess.<anonymous> (/home/runner/work/_actions/easingthemes/ssh-deploy/main/dist/index.js:2:2603)
    at ChildProcess.emit (node:events:527:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12) {
  code: 23
}
❌ [Rsync] stderr: 
rsync: [generator] recv_generator: mkdir "<dir-name>" failed: Permission denied (13)
*** Skipping any contents from this failed directory ***
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1333) [sender=3.2.3]

@vicenterzl
Copy link

+1

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Issues without activity label Apr 22, 2023
@easingthemes easingthemes removed the stale Issues without activity label Apr 23, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Issues without activity label May 24, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2023
@easingthemes easingthemes removed the stale Issues without activity label Feb 27, 2024
@easingthemes easingthemes reopened this Feb 27, 2024
@liushuai05
Copy link

+1

1 similar comment
@weblink-hr
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants