Custom (de)serializers

[earthboundkid]

I would be nice to be able to support alternative JSON libraries, like #87 and #88. JSON is just one kind of serialization. There's also XML, a la #79 / #82, and presumably other options like binary (Protobuf?) and whatnot.

What if we add a new API like

type Serializer = func(v any) ([]byte, error)
type Deserializer = func([]byte, v any) error

func (rb *Builder) Serialize(s Serializer, v any)
func (rb *Builder) Deserialize(d Deserializer, v any)

// Used if s or d are nil
var (
    DefaultSerializer = json.Marshal
    DefaultDeserializer = json.Unmarshal
)

// Usage
func init() {
  requests.DefaultSerializer = gojson.Marshal
  requests.DefaultDeserializer = gojson.Unmarshal
}

err := requests.
  URL(url).
  Serialize(nil, req).
  Deserialize(nil, res).
  Fetch(ctx)

@EvilBorsch, what do you think of this idea?

[earthboundkid]

It should probably also have a string param for (default) content type.

[earthboundkid]

Having a default content type would also help with the existing issue of application/json getting added whether you want it or not. It could just be a setting that you can toggle.

[EvilBorsch]

I think it looks good architecturally, but bad from a ux point of view. It is convenient and understandable for developers to use ToJSON, if server return for example xml, most convient way is to find ToXML, not to call Serialize with parameters.

It seems that for complete happiness it is only necessary to give the opportunity to speed up toJSON method (keep in mind that 90%+ usecases will return JSON). Moreover, it seems to me, that this should not be within the framework of conditional FastToJSON, but in the form of a GLOBAL override of the serializer/deserializer for json especially. Because memorize that in each request we need to override serialize is quite hard.

[EvilBorsch]

Im agree with you, but i think its a good idea to have in library this two options together, so you can use another json serializer/deserializer globally and use ToJSON with this global serializer and overwrite this behaviour, using this brand new Serialize method if you want to.

[EvilBorsch]

Anyway i will be happy if at least your variant with Serialize/Deserialize will go to master. Because gojson trully improve serialization/deserialization, and we can use it on our high rps interaction between services :)

[earthboundkid]

I’ve been busy but I might have time to work on this next week.

[earthboundkid]

I started working on #91.

[EvilBorsch]

Thank you for your work!