You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the course of working on #78, testing made it seem like Go's treeshaker isn't quite aggressive enough to shake out an unused init() from packages you don't use. So maybe we should move x/net/html into a reqhtml subpackage and TestConfig into reqtest.
The reqtest package could also have an always error transport and some other test mocking stuff. It could be really aggressive and also have the Replay and Caching transports in it.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
In the course of working on #78, testing made it seem like Go's treeshaker isn't quite aggressive enough to shake out an unused init() from packages you don't use. So maybe we should move x/net/html into a reqhtml subpackage and TestConfig into reqtest.
The reqtest package could also have an always error transport and some other test mocking stuff. It could be really aggressive and also have the Replay and Caching transports in it.
I dunno. It's worth thinking about.
Beta Was this translation helpful? Give feedback.
All reactions