requests.ErrorJSON(data any) validator

[earthboundkid]

Create a validator that checks the status code and if it's bad, attempts to marshal the JSON to the object provided. It would need to still return an error to prevent further handling, but the error could be a sentinel instead of a ResponseError, so it's cheaper.

[earthboundkid]

Maybe ErrorJSON(data any, statuses …int).

[earthboundkid]

Yes, that's exactly the idea. I haven't had the time to play with it and validate it, so I haven't done a commit yet but I think it will end up there.

[earthboundkid]

One open question: should it return a sentinel error? A response error? The unmarshaled JSON as an error?

[lucasepe]

in the above example I return the unmarshalled JSON (into the user custom error) but doing so we lose the status code and other useful response errors ...so maybe it might be useful to return a sentinel error.

[earthboundkid]

Maybe something like

type ErrorJSONError struct { *ResponseError }

func ErrorJSON(v any, acceptStatuses...int) ResponseHandler {
   return func(res * http.Response) error {
      for _, code: = range acceptStatuses {
         if res.StatusCode == code {
            return nil
         }
      }
      if res.Body == nil {
         return fmt.Errorf("%w: unexpected status: %d", ( * ResponseError)(res), res.StatusCode)
      }
      data, err: = io.ReadAll(res.Body)
      if err != nil {
         return err
      }
      if err = json.Unmarshal(data, v);
      err != nil {
         return err
      }
      return fmt.Errorf("receive an error response: %q", ErrorJSONError{ (*ResponseError)(res) })
   }
}

[earthboundkid]

Or maybe

type ErrorJSONError struct { 
  *ResponseError 
  Data any
}

Or maybe even generics?

type ErrorJSONError[T any] struct { 
  *ResponseError 
  Data T
}

I think this is doable?

[lucasepe]

Yes this is what I was thinking. Il ven 8 apr 2022, 18:32 Carl Johnson ***@***.***> ha scritto:

…

Or maybe type ErrorJSONError struct { *ResponseError Data any } Or maybe even generics? type ErrorJSONError[T any] struct { *ResponseError Data T } I think this is doable? — Reply to this email directly, view it on GitHub <#32 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEO5JPGBG7CULNHL7PCTDDVEBNRPANCNFSM5LKT3WPA> . You are receiving this because you commented.Message ID: ***@***.***>

[WTFender]

Just wanted to add a +1 for the ability to parse JSON responses from errors.
@carlmjohnson ty! this pkg got me quickly started with rest apis in golang; wish I had more experience and was able to contribute on this.

[earthboundkid]

See #63.