server: refactor video highlighting, fix videos not getting highlighted in add previews #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-06-20 22:30:45.467632921 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-06-20 22:30:46.023635977 +0000
@@ -30,19 +30,19 @@
�[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js �[39m�[1m�[2m 0.34 kB�[22m�[1m�[22m�[2m │ gzip: 0.26 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js �[39m�[1m�[2m 0.60 kB�[22m�[1m�[22m�[2m │ gzip: 0.32 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mplaceholder-hash.js �[39m�[1m�[2m 1.04 kB�[22m�[1m�[22m�[2m │ gzip: 0.48 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js �[39m�[1m�[2m 2.00 kB�[22m�[1m�[22m�[2m │ gzip: 0.96 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js �[39m�[1m�[2m 2.00 kB�[22m�[1m�[22m�[2m │ gzip: 0.95 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mRoomList-hash.js �[39m�[1m�[2m 2.31 kB�[22m�[1m�[22m�[2m │ gzip: 1.08 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPrivacy-hash.js �[39m�[1m�[2m 2.64 kB�[22m�[1m�[22m�[2m │ gzip: 1.29 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js �[39m�[1m�[2m 5.43 kB�[22m�[1m�[22m�[2m │ gzip: 1.34 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mYoutubePlayer-hash.js �[39m�[1m�[2m 5.86 kB�[22m�[1m�[22m�[2m │ gzip: 2.22 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mYoutubePlayer-hash.js �[39m�[1m�[2m 5.86 kB�[22m�[1m�[22m�[2m │ gzip: 2.21 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js �[39m�[1m�[2m 10.79 kB�[22m�[1m�[22m�[2m │ gzip: 4.49 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.79 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js �[39m�[1m�[2m 11.59 kB�[22m�[1m�[22m�[2m │ gzip: 4.78 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js �[39m�[1m�[2m 12.40 kB�[22m�[1m�[22m�[2m │ gzip: 6.42 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.98 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.97 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js �[39m�[1m�[2m 16.35 kB�[22m�[1m�[22m�[2m │ gzip: 5.54 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.53 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 164.14 kB�[22m�[1m�[22m�[2m │ gzip: 51.45 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.52 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 164.20 kB�[22m�[1m�[22m�[2m │ gzip: 51.45 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.54 kB�[39m�[22m�[2m │ gzip: 248.17 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.36 kB�[22m
-�[32m✓ built in 25.65s�[39m
+�[32m✓ built in 25.14s�[39m |
Passing run #1986 ↗︎
Details:
Review all test suite changes for PR #1778 ↗︎ |
|||||||||||||||
dyc3
force-pushed
the
fix-highlighted-vids
branch
2 times, most recently
from
4f972eb
to
1700df9
Compare
|
I've just tested this and it should be good to go. |
dyc3
force-pushed
the
fix-highlighted-vids
branch
from
1700df9
to
aa69801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better UX when copying links from youtube playlists, OTT is supposed to highlight the video that is in the link, while still fetching the playlist, if possible. This PR fixes that, and refactors the feature to make it a little more reliable.
fixes #1777