Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor OmniPlayer to expose the player controls via a composable #1232

Open
dyc3 opened this issue Jan 17, 2024 · 0 comments
Open

Refactor OmniPlayer to expose the player controls via a composable #1232

dyc3 opened this issue Jan 17, 2024 · 0 comments
Labels
client Improvements or additions to the web client refactor Something needs to be reworked to improve code quality

Comments

@dyc3
Copy link
Owner

dyc3 commented Jan 17, 2024

Is your feature request related to a problem? Please describe.

The current method of interacting with OmniPlayer and the players that it wraps is extremely cumbersome and error prone.

Describe the solution you'd like

Similar to useRoomApi, provide a useMediaPlayer composable that provides a reference to something that can expose the controls of OmniPlayer, and provide references to stuff like the current position, volume, subtitle track, etc in a way that allows vue's reactivity to take care of updating UI values.

Additional context

No response
@dyc3 dyc3 added client Improvements or additions to the web client refactor Something needs to be reworked to improve code quality labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client Improvements or additions to the web client refactor Something needs to be reworked to improve code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dyc3