Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support adding new instances from existing ones #130

Open
stevenvo opened this issue Oct 22, 2021 · 7 comments · May be fixed by #283
Open

support adding new instances from existing ones #130

stevenvo opened this issue Oct 22, 2021 · 7 comments · May be fixed by #283
Labels
✨ feature request New feature or request todo
Milestone

Comments

@stevenvo
Copy link

currently the multi instance installation is a one off process. The script requires removal of the previous installation in other to do a new installation. Can it get a bit smarter to allow adding new instances without removal of existing ones (which might already support production printers running)
https://github.com/th33xitus/kiauh/blob/f231fa9c69191f23277b4e3319f6b675bfa0ee42/scripts/install_klipper.sh#L15

@dw-0
Copy link
Owner

dw-0 commented Oct 22, 2021

It's planned, yes. I just need to find time to get around that :)

@Nuck-TH
Copy link

Nuck-TH commented Nov 19, 2023

To add to this: i think even when installing one instance it should ask for name like when installing multiple ones to avoid need of moving data from printer_data dir to [name]_data one and according manual changes in configs.

@HakunMatat4
Copy link

@dw-0 do you have any ETA like a month or 3 months to get this released?
I have one printer, I have spent easily the last 2h trying to find anything I could to assist me in adding a second printer without deleting anything but no luck.
Atm, I will have to backup everything and start from scratch again :(

Thank you

@dw-0
Copy link
Owner

dw-0 commented Nov 20, 2023

Sorry, there is no ETA yet as im not implementing that feature in the current bash version of KIAUH anymore. Im currently doing a full rewrite of the application which then will be able to easily add or remove klipper instances. This will come in KIAUH v6. The current v5 will not receive that feature anymore, its just way too much hassle to implement that with bash @R4toLoko

Atm, I will have to backup everything and start from scratch again :(

Im not sure why it seems to be such a big deal. Make a backup of the printer_data directory, then uninstall klipper and re-install the desired amount of instances. Copy over the configs into one of the new printer_x_data folder and adapt the configs. Done.
That's a process of max 20-25min with slow internet and not being used to copy and edit files on a linux system.

@HakunMatat4
Copy link

Atm, I will have to backup everything and start from scratch again :(

Im not sure why it seems to be such a big deal. Make a backup of the printer_data directory, then uninstall klipper and re-install the desired amount of instances. Copy over the configs into one of the new printer_x_data folder and adapt the configs. Done.
That's a process of max 20-25min with slow internet and not being used to copy and edit files on a linux system.

I mean, imagine if user had to uninstall and install AndroidOS from their phone in order to add a work profile to their current personal profile?!
Or reinstall Linux on my laptop because you know, I only installed it with a single user account.

Being able to manage multiple instances/multiple accounts without requiring deleting data no matter if you have back-up, is a basic functionality of basically any app no matter if mobile, Windows/Linux/Mac.

It isn't a "plus", it's a basic functionality, that is all!

Thanks anyway

@dw-0
Copy link
Owner

dw-0 commented Nov 20, 2023

Atm, I will have to backup everything and start from scratch again :(

Im not sure why it seems to be such a big deal. Make a backup of the printer_data directory, then uninstall klipper and re-install the desired amount of instances. Copy over the configs into one of the new printer_x_data folder and adapt the configs. Done.
That's a process of max 20-25min with slow internet and not being used to copy and edit files on a linux system.

I mean, imagine if user had to uninstall and install AndroidOS from their phone in order to add a work profile to their current personal profile?! Or reinstall Linux on my laptop because you know, I only installed it with a single user account.

Being able to manage multiple instances/multiple accounts without requiring deleting data no matter if you have back-up, is a basic functionality of basically any app no matter if mobile, Windows/Linux/Mac.

It isn't a "plus", it's a basic functionality, that is all!

Thanks anyway

Now imagine having to set up Klipper, Moonraker, Mainsail/Fluidd and whatnot yourself. All without this script AND then figure out how to set up multiple instances of it. It's possible of course, and there are installation guides for manual installs everywhere.

However. Your comparisons are limping and show that you have no real idea what you're talking about. But that's fine. However, there is a large dose of entitlement in you, which again (in my eyes) is not okay.

@stubbs41
Copy link

Atm, I will have to backup everything and start from scratch again :(

Im not sure why it seems to be such a big deal. Make a backup of the printer_data directory, then uninstall klipper and re-install the desired amount of instances. Copy over the configs into one of the new printer_x_data folder and adapt the configs. Done.
That's a process of max 20-25min with slow internet and not being used to copy and edit files on a linux system.

I mean, imagine if user had to uninstall and install AndroidOS from their phone in order to add a work profile to their current personal profile?! Or reinstall Linux on my laptop because you know, I only installed it with a single user account.

Being able to manage multiple instances/multiple accounts without requiring deleting data no matter if you have back-up, is a basic functionality of basically any app no matter if mobile, Windows/Linux/Mac.

It isn't a "plus", it's a basic functionality, that is all!

Thanks anyway

Yeah its not hard at all to backup configs, uninstall via kiauh and then re-install with additional instances. It is realistically 15 mins. I do this a fair amount as its so easy. Just copy your configs back in for each one after. Sure its not always fun to take a few minutes and re-setup the Printers in Mainsail interface but it's not hard. I have saved so many hours using this github repo that the 2 minutes to add the mundane stuff back in is nothing.

Adding in other instances while keeping the instance already created has not worked out well for me but that has nothing to do with Kiauh and because of the complexity of adding one instance after another is setup Deleting and Reinstalling is so easy. Mind you the adding of another instance on your own without Kiauh is feasible, the challenge is what you need to do afterwards will cause the issues when you want to add other code and then have to figure out whats wrong only to find out 5 days later it's because you added another instance on top of one already setup.

Bottom Line in my opinion is remove and re-install via kiauh unless you live for troubleshooting unsupported features or code. Either way good luck. For what its worth I'm not calling anyone out I'm only sharing my experience. Take it how you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature request New feature or request todo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants