-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure to compile on systems that do not define TIOCSTI #494
Comments
Just hit the same problem on Cygwin. I'm using this locally:
|
Thank you @dvorka! For the record, here is the full patchset we apply to hstr 3.1 for the Haiku version: (just in case you find something useful) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Even if now most of the code has guards like in:
https://github.com/dvorka/hstr/blob/4dca4c72d7db104b2c1043551d0d8dc611e0e260/src/hstr_utils.c#146
There's still one spot where the usage of TIOCSTI is not guarded:
hstr/src/hstr_utils.c
Line 170 in 4dca4c7
For context, found this while updating the Haiku port/package for hstr (still on 2.6 there). There, we mostly need to add
|| defined(__HAIKU__)
on the same lines with WSL, CYGWIN to avoid TIOCSTI stuff, and next to FreeBSD (for the ncurse.h includes in that case).Will try to come up with cleaner patches, to see if those can be upstreamed, but would be nice to see an official way for this missing "TIOCSTI guard".
Thanks for your work @dvorka!
The text was updated successfully, but these errors were encountered: