Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests #4

Open
dvdvgt opened this issue Sep 29, 2019 · 7 comments
Open

Adding tests #4

dvdvgt opened this issue Sep 29, 2019 · 7 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@dvdvgt
Copy link
Owner

dvdvgt commented Sep 29, 2019

Adding tests is something I've been meaning to do for a long time but never really knew were to start. Help would be greatly appreciated! :) The tests should preferably use pytest.

@dvdvgt dvdvgt added help wanted Extra attention is needed hacktoberfest labels Sep 29, 2019
@Bhyan
Copy link

Bhyan commented Sep 30, 2019

Hey man, I'd like to get this issues. I have experience with tests in Java, but i want to study pytest. I think I can help you!!

@adityaarakeri
Copy link

@XCAL1BUR I Can work on this.

@dvdvgt
Copy link
Owner Author

dvdvgt commented Sep 30, 2019

Hey @Bhyan , @adityaarakeri ! Thank you both very much for offering your help. I really appreciate it! @Bhyan replied first so I will assign him to this issue. @adityaarakeri I can assign you as well if you want to work on it too or feel free to find something else that might improvable. All PR's are more than welcome :)

@dvdvgt dvdvgt added the enhancement New feature or request label Sep 30, 2019
@Bhyan
Copy link

Bhyan commented Oct 15, 2019

Sorry but I will not be able to perform the tests due to some personal issues. @adityaarakeri how would you assume?

@dvdvgt
Copy link
Owner Author

dvdvgt commented Oct 16, 2019

Hey @Bhyan! Thanks for reaching out to me. I will unassign you from this issue. I wish you all the best!

@dvdvgt
Copy link
Owner Author

dvdvgt commented Oct 16, 2019

@adityaarakeri are you still interested in writing some tests? I would really appreciate your help as would I if somebody else reading this would like take on this issue!

@adityaarakeri
Copy link

@XCAL1BUR i got swamped with some other things 🤷‍♂️, the PR might be delayed. i will get back on this at a later point. if any one wants to work on it right now, they can go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants