Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable to revoke users #1

Open
brnl opened this issue Feb 27, 2020 · 0 comments
Open

Bug: Unable to revoke users #1

brnl opened this issue Feb 27, 2020 · 0 comments

Comments

@brnl
Copy link

brnl commented Feb 27, 2020

The script is unable to revoke users. It hangs on the menu system of openvpn-install.sh while trying to revoke user redacted3:

null_resource.openvpn_update_users_script[0] (remote-exec): Revoking certificate for user redacted3!
null_resource.openvpn_update_users_script[0] (remote-exec): 
Welcome to OpenVPN-install!
null_resource.openvpn_update_users_script[0] (remote-exec): The git repository is available at: https://github.com/angristan/openvpn-install

null_resource.openvpn_update_users_script[0] (remote-exec): It looks like OpenVPN is already installed.

null_resource.openvpn_update_users_script[0] (remote-exec): What do you want to do?
null_resource.openvpn_update_users_script[0] (remote-exec):    1) Add a new user
null_resource.openvpn_update_users_script[0] (remote-exec):    2) Revoke existing user
null_resource.openvpn_update_users_script[0] (remote-exec):    3) Remove OpenVPN
null_resource.openvpn_update_users_script[0] (remote-exec):    4) Exit

null_resource.openvpn_update_users_script[0] (remote-exec): Select the existing client certificate you want to revoke
null_resource.openvpn_update_users_script[0] (remote-exec):      1) redacted1
null_resource.openvpn_update_users_script[0] (remote-exec):      2) redacted2
null_resource.openvpn_update_users_script[0] (remote-exec):      3) redacted3
null_resource.openvpn_update_users_script[0] (remote-exec):      4) redacted4
null_resource.openvpn_update_users_script[0] (remote-exec): Select one client [1-4]:

The problem seems that openvpn-install.sh has no way to accept the name of the user as an select option: See line 1080 in openvpn-install.sh:

echo "Select the existing client certificate you want to revoke"
tail -n +2 /etc/openvpn/easy-rsa/pki/index.txt | grep "^V" | cut -d '=' -f 2 | nl -s ') '
if [[ "$NUMBEROFCLIENTS" = '1' ]]; then
	read -rp "Select one client [1]: " CLIENTNUMBER
else
	read -rp "Select one client [1-$NUMBEROFCLIENTS]: " CLIENTNUMBER
fi

Do you have an idea to work around this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant