Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Health Checks for Services #34

Open
dudash opened this issue Jun 4, 2019 · 1 comment
Open

Add Health Checks for Services #34

dudash opened this issue Jun 4, 2019 · 1 comment
Labels
enhancement Update to an existing capability help wanted Extra attention is needed

Comments

@dudash
Copy link
Owner

dudash commented Jun 4, 2019

Note that these check will have to run on different ports than the main service in order to support deployment with mTLS enabled.

So this work is to 1) update the service code to support a readiness/liveliness via alt route/port and 2) update config yaml to include the checks on those route/ports

A couple links that might help:
@dudash dudash added the enhancement Update to an existing capability label Jun 4, 2019
@dudash dudash added the help wanted Extra attention is needed label Feb 25, 2020
@dudash
Copy link
Owner Author

dudash commented Mar 18, 2020

this might be OBE - looks like this is easier now:
https://istio.io/docs/ops/configuration/mesh/app-health-check/

sidecar.istio.io/rewriteAppHTTPProbers: "true"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Update to an existing capability help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dudash