Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add test to check format and totals of CSV files on pull-requests #521

Open
dmackie opened this issue Jul 1, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dmackie
Copy link
Collaborator

dmackie commented Jul 1, 2020

Is your feature request related to a problem? Please describe.
It is pretty easy to accidentally commit a CSV that breaks where a comma may be left off or one of the values have a transposed digit.

Describe the solution you'd like
An automatic test is run on pull requests that confirms the CSV is formatted correctly, and that all the values add up to the total as a checksum.

Describe alternatives you've considered
Users should be checking their own and others work when it is submitted but a line of numbers if very easy to miss a small mistake like a transposed figure, or when you have read off the wrong number of the original source.

Additional context
Points to my recent mistake of committing CSV file with over 1.6 Million confirmed cases and not picking up that this number was way too big. It was tests number I kept misreading off the image.

@dmackie dmackie added the enhancement New feature or request label Jul 1, 2020
@vukosim
Copy link
Member

vukosim commented Jul 2, 2020

@dmackie do you have any dummy code we can try out or a dummy process?

So what happens, a pull request comes through, what tests run and what gets added to the pull request to show things are okay?

Is this possible in Github with actions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants