-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log the right patchDir when error happens #488
Comments
Using patch-package to patch patch-package 鉂わ笍 |
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! 馃憢
Firstly, thanks for your work on this project! 馃檪
Today I used patch-package to patch
[email protected]
for the project I'm working on.MY PROBLEM : When I specify
--patch-dir
as an argument, and then the patch application fails, the log outputs the wrongpatch-dir
. It outputs the defaultpatchDir
value (patches/
) instead of the specified one. When this happens in CI, it causes long debugging sessions to figure out what happens, because we have multiple patches and we don't know which one errored.Example command :
patch-package --patch-dir patches/change-sections-order-in-security-privacy-settings
Obtained output :
Expected last lines of output to be instead :
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: