Unnecessary loop

[yyzdtccjdtc]

rust-brotli/src/enc/backward_references/hq.rs

Line 920 in 5d82b69

'continue30: loop {

This loop continue30 is unnecessary because it will eventually break at line 1018. If we remove this loop and change all the break 'continue30; into continue and change all the break 'break29; into break, the execution time will decreased from 3.76s to 3.43s based on my test, which is a 1.1x speedup.

Hope this information helps!

[lesniewski]

I believe this code was auto-generated, right @danielrh ?

[pengfei-su]

Hello, I just run into this. Will it be improved since this 10% speedup looks easy to get?

[pengfei-su]

@danielrh Is it a bug or an unnecessary loop? The last statement in this loop is a break, indicating it is executed once whatsoever. I don't see why 'continue30: loop{...} is needed.