This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 7
Caching #1
Labels
enhancement
New feature or request
Comments
I like the two classes approach - would only add a GithubSponsors::cached()->isSponsoredBy('Gummibeer'); |
Hello guys! If you don't mind I'd like to work on this (this is my first public contribution so I want to make sure that I understand what do you require 😅) I'll try to rephrase the proposed solution to make sure that I'm following:
Please forgive me if that's not what you want and I've wasted your time 😅🙏 |
Heya! Thanks for willing to help out. We'll need to rethink this quite a bit since the internals have changed in the meantime. I atm don't have time for this so we'll need to hold off on this until I can find some time to wrap my head around it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Performing GraphQL calls can be costly and take quite a bit of time. Ideally I'd like to have dedicated caching support in the library. Most calls to check for sponsorships of GitHub users or to retrieve a list of sponsors don't need to be checked every second.
The way I see it we can ship a decorator for the
GitHubSponsors
client. This would look like as follows:Maybe a common interface is needed?
I think this class should require a
Psr\SimpleCache\CacheInterface
implementation to handle the caching. For Laravel it can be retrieved from the already set cache store. We can add options to thegithub-sponsors.php
config file to set the specific cache store and timeouts.The text was updated successfully, but these errors were encountered: