Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the document about gnu makefiles has a tiny (but significant) mistake #86

Closed
zlago opened this issue Apr 28, 2024 · 3 comments
Closed

the document about gnu makefiles has a tiny (but significant) mistake #86

zlago opened this issue Apr 28, 2024 · 3 comments
Assignees
@dreamos82

Comments

@zlago
Copy link

zlago commented Apr 28, 2024

the document claims GNU make looks for GNUMakefile (uppercase M), its actually GNUmakefile (lowercase m)

$ touch GNUMakefile
$ make
make: *** No targets specified and no makefile found.  Stop.
$ touch GNUmakefile
$ make
make: *** No targets.  Stop.
@dreamos82 dreamos82 self-assigned this Apr 28, 2024
@dreamos82
Copy link
Member

Thanks for reporting it, @zlago, wow that was hard to spot! :)

I can fix it on a branch I've created with few other fixes. But if you want contribute, feel free to open a PR and me or @DeanoBurrito will merge it! (my branch will not be merged soon).

Thanks again!

dreamos82 added a commit that referenced this issue May 5, 2024
@dreamos82
Fix file name (issue #86)
da3c509
@dreamos82
Copy link
Member

Hi @zlago i've added the change you suggeste in a branch with other fixed. It will be merged soon(er or later :))
Thanks again for reporting! I'll close the issue once the fix will be merged into master)

DeanoBurrito pushed a commit that referenced this issue May 14, 2024
@dreamos82
Debugging minor changes (#88)
1a02d1e 
* Minor fixes in the appendices section

* minor syntax fix to acpi chapter

* clarify length field in acpisdt header

* Fix file name (issue #86)

* minor changes to memory management section

* Minor changes to heap chapter

* Requested changes
@dreamos82
Copy link
Member

Hi @zlago i made the change in PR #88, so i'm going to close this issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamos82 dreamos82

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dreamos82 @zlago