Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deadlock if slot migration is canceled after beggining #2968

Closed
BorysTheDev opened this issue Apr 29, 2024 · 0 comments · Fixed by #2992
Closed

deadlock if slot migration is canceled after beggining #2968

BorysTheDev opened this issue Apr 29, 2024 · 0 comments · Fixed by #2992
Assignees
@chakaz
Labels
bug Something isn't working
Milestone
dfly cluster v2

Comments

@BorysTheDev
Copy link
Contributor

BorysTheDev commented Apr 29, 2024 •
edited

Also not all keys are removed after cancel from the target node
@BorysTheDev BorysTheDev added the bug Something isn't working label Apr 29, 2024
@BorysTheDev BorysTheDev added this to the dfly cluster v2 milestone Apr 29, 2024
@BorysTheDev BorysTheDev self-assigned this Apr 29, 2024
BorysTheDev added a commit that referenced this issue Apr 29, 2024
@BorysTheDev
fix: fix deadlock and slot flush for migration cancel #2968
91f2ad6
BorysTheDev added a commit that referenced this issue Apr 30, 2024
@BorysTheDev
fix: fix deadlock and slot flush for migration cancel #2968 (#2972)
415839d 
* fix: fix deadlock and slot flush for migration cancel #2968
chakaz added a commit that referenced this issue May 1, 2024
@chakaz
fix(cluster-migration): Support cancelling migration right after star…
b36eef6 
…ting it

This fixes a few small places, but most importantly it does not allow a
migration to start before both the outgoing and incoming side received
the updated config. This solves a few edge cases.

Fixes #2968
@chakaz chakaz mentioned this issue May 1, 2024
Merged
@adiholden adiholden assigned chakaz and unassigned BorysTheDev May 2, 2024
chakaz added a commit that referenced this issue May 2, 2024
@chakaz
fix(cluster-migration): Support cancelling migration right after star…
082aba0 
…ting it (#2992)

* fix(cluster-migration): Support cancelling migration right after starting it

This fixes a few small places, but most importantly it does not allow a
migration to start before both the outgoing and incoming side received
the updated config. This solves a few edge cases.

Fixes #2968

* add TODO

* fix test

* gh comments and fixes

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chakaz chakaz

Labels
bug Something isn't working
Projects
None yet
Milestone
dfly cluster v2
Development

Successfully merging a pull request may close this issue.

fix(cluster-migration): Support cancelling migration right after starting it dragonflydb/dragonfly
2 participants
@BorysTheDev @chakaz