New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow server resurrection after repltakeover #2860

Open

romange opened this issue Apr 7, 2024 · 1 comment

Labels

Collaborator

romange commented Apr 7, 2024

Today a dragonfly master shutdown upon successful repltkeover flow.

@ashotland suggests that instead dragonfly will stop accepting connections on the main port and will close all the existing connections.

It will still be possible to revert this operation via the admin port by allowing the connection to connect to the main port.

romange added the enhancement label

Collaborator Author

romange commented Apr 9, 2024

I appreciate some of the advantages of FAILOVER design:

It allows aborting the failover operation if needed
It keeps the master data by transforming the master to replica in case of the successful takeover.
it allows a forceful failover, with some data loss but may still be very useful if master does not succeed to failover using the usual path.

For more details, see redis/redis#8315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment