Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure service name #178

Closed
34fathombelow opened this issue Apr 30, 2024 · 2 comments · Fixed by #187
Closed

Ability to configure service name #178

34fathombelow opened this issue Apr 30, 2024 · 2 comments · Fixed by #187

Comments

@34fathombelow
Copy link

It would be awesome if we could define the name of the service. Currently the service name is created statically by the name defined in the Dragonfly CR. Being able to customize the service name could be very helpful and speed up a migration of an existing Redis service.

If accepted it would make sense to add it to the serviceSpec field.

serviceSpec:
name: dragonfly-us-west-1

@Pothulapati
Copy link
Collaborator

Being able to customize the service name could be very helpful and speed up a migration of an existing Redis service.

Can you explain more on this? We can add a field but I think a better solution is to actually understand how this specifically helps with migrations.

Thanks.

@34fathombelow
Copy link
Author

Thank you for your swift response and eagerness to help out.

Can you explain more on this? We can add a field but I think a better solution is to actually understand how this specifically helps with migrations.

Certain applications like Argo CD predefine an existing service name to use. This can be customized but using an existing name could help a migration. Also certain ingress controllers require a service name for a route. Rather than changing the existing name before a migration is complete a user could use an existing service name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants