Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

English documentations #250

Closed
Sojaner opened this issue Mar 20, 2024 · 1 comment
Closed

English documentations #250

Sojaner opened this issue Mar 20, 2024 · 1 comment

Comments

@Sojaner
Copy link

Sojaner commented Mar 20, 2024

I have translated the code base's documentation, comments, and strings into English.

I have also fixed some vulnerability issues and fixed the failing unit tests. I will soon create a pull request with these fixes. 馃檪

The code is here: https://github.com/Sojaner/DotnetSpider/tree/en-updated what do you think, should I create a new library version in English, or what do you think? The translations are on the master branch of my fork at https://github.com/Sojaner/DotnetSpider and I will later on create the English version of the NuGet package.

Also, I have developed a dotnet tool that can translate the whole code base at once. It's called transooner for anyone who ends up here and is interested.

@zlzforever
Copy link
Collaborator

Welcome your PR~ Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants