Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] we should use instantiateStreaming #102200

Open
kg opened this issue May 14, 2024 · 1 comment
Open

[wasm] we should use instantiateStreaming #102200

kg opened this issue May 14, 2024 · 1 comment
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono
Milestone

Comments

@kg
Copy link
Contributor

kg commented May 14, 2024

We should try to use https://developer.mozilla.org/en-US/docs/WebAssembly/JavaScript_interface/instantiateStreaming_static to compile and instantiate the runtime WASM module in one step instead of two separate steps. Apparently if you do it in split stages like we're doing now, Safari has to make expensive temporary copies of data and buffer it up. From my profiles of Firefox it may also be beneficial to do instantiateStreaming there too.

This requires some complex internal changes to unify our separate stages into one stage.

@kg kg added the arch-wasm WebAssembly architecture label May 14, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 14, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 14, 2024
@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 17, 2024
@lewing lewing added this to the 9.0.0 milestone May 21, 2024
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono
Projects
None yet
Development

No branches or pull requests

4 participants