Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify diagnostics more broadly in integration tests #10247

Open
333fred opened this issue Apr 10, 2024 · 2 comments
Open

Verify diagnostics more broadly in integration tests #10247

333fred opened this issue Apr 10, 2024 · 2 comments
Assignees
Labels
area-compiler Umbrella for all compiler issues test scenario
Milestone

Comments

@333fred
Copy link
Member

333fred commented Apr 10, 2024

#10232 (comment)

There are some unit test files (such as CodeGenerationIntegrationTest that don't verify C# or razor diagnostics of the code they produce. We need to do this much more generally in all our integration tests.

@chsienki
Copy link
Contributor

@jjonescz @333fred I'll assign you both this one, but I assume @jjonescz will get to it first due to @333fred upcoming OOF.

Let's try and get this done soon, we're making a ton of changes and want to make sure our test coverage is as good as it can be to catch regressions.

@jjonescz
Copy link
Contributor

I'm looking into this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-compiler Umbrella for all compiler issues test scenario
Projects
None yet
Development

No branches or pull requests

3 participants