-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't stomp on *DependsOn properties #2 #9755
Labels
Comments
Enforcing this rule could be an interesting BuildCheck |
Would such properties by manualy configured by the author+user, or might there be any 'magic' how to detect properties that should actually behave as items? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
There are couple sdk ***DependsOn properties that allow injecting custom target as dependencies of sdk targets. However big portion of those properties are force set within sdk.targets - so users'd need to include sdk.targets explicitly to be able to set them (we even document a need for this workaround in the documentation mentioned below).
#4922 fixed couple, #9703 fixed one, but we have still dozens that we force overwrite.
e.g. the externally documented
Commonly overridden DependsOn properties
BuildDependsOn
:msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets
Lines 891 to 895 in 23f7752
CleanDependsOn
:msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets
Lines 5675 to 5682 in 23f7752
CompileDependsOn
:msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets
Lines 3595 to 3607 in 23f7752
But there are others that seem as potentially usefull - CoreBuildDependsOn, RebuildDependsOn, RunDependsOn, PublishDependsOn etc. etc.
Suggestion
Select a usefull subset (or probably all?) of the DependsOn properties in common target files (search) and redefine those with the additive pattern:
--->
The text was updated successfully, but these errors were encountered: