-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GB18030] Audit shipped props and targets for usage of Substring on paths #10075
Comments
In msbuild we have just the single usage being fixed. There are couple similar usages in Blazor targets in sdk: https://github.com/search?q=repo%3Adotnet%2Fsdk+path%3A**%2F*.targets+substring&type=code Once the fix is inserted we should reach out to them or shoot a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
Based on issue identified by @ilonatommy and @ladipro (#10063)
Substring doesn't resect surrogate chars
Sample GH query (though needs to be tunned up, or just search locally): https://github.com/search?q=Substring+repo%3Adotnet%2Fmsbuild+path%3A**%2F*.targets&type=code&ref=advsearch
The text was updated successfully, but these errors were encountered: