Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update LoggerMessage.Define() to be source generated logging #40870

Open
Yun-Ting opened this issue May 13, 2024 · 2 comments
Open

update LoggerMessage.Define() to be source generated logging #40870

Yun-Ting opened this issue May 13, 2024 · 2 comments
Assignees
Labels
dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 ⌚ Not Triaged Not triaged

Comments

@Yun-Ting
Copy link

Type of issue

Outdated article

Description

Most of the content on that high perf logging page talks about LoggerMessage.Define() which may have been state of the art around .NET Core 3 but as soon as source generated logging came out. Please update this documentation to reflect the above.

Page URL

https://learn.microsoft.com/en-us/dotnet/core/extensions/high-performance-logging#define-a-logger-message

Content source URL

https://github.com/dotnet/docs/blob/main/docs/core/extensions/high-performance-logging.md

Document Version Independent Id

3f5f1b6e-06ac-cc07-48cd-b8b957a4abbb

Article author

@IEvangelist

Metadata

  • ID: aa00c051-c047-bbcd-5e25-ca6a722b51c3
  • Service: dotnet-fundamentals
@issues-automation issues-automation bot added dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 labels May 13, 2024
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label May 13, 2024
@Yun-Ting
Copy link
Author

cc @tarekgh

@tarekgh
Copy link
Member

tarekgh commented May 13, 2024

We may need to copy the summary from the page https://learn.microsoft.com/en-us/dotnet/core/extensions/logger-message-generator#summary and refer to the page too.

@tarekgh tarekgh self-assigned this May 13, 2024
@tarekgh tarekgh removed the ⌚ Not Triaged Not triaged label May 13, 2024
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 ⌚ Not Triaged Not triaged
Projects
None yet
Development

No branches or pull requests

3 participants