-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing C# 13 example #40796
Labels
doc-enhancement
Improve the current content [org][type][category]
dotnet-csharp/svc
Pri3
📌 seQUESTered
Identifies that an issue has been imported into Quest.
whats-new/subsvc
Comments
BillWagner
added
the
doc-enhancement
Improve the current content [org][type][category]
label
May 19, 2024
I've got a PR that updates this file now. I'll update the example. |
BillWagner
added a commit
to BillWagner/docs
that referenced
this issue
May 19, 2024
This commit fixes dotnet#40796
sequestor
bot
added
📌 seQUESTered
Identifies that an issue has been imported into Quest.
and removed
🗺️ reQUEST
Triggers an issue to be imported into Quest.
labels
May 20, 2024
BillWagner
added a commit
that referenced
this issue
May 20, 2024
* Add params collections Update descriptions for the `params` modifier to allow collections. Fixes #40005 * edit pass, phase one. Update sample code and markdown extensions. Grammar pass. * edit pass Move samples, edit for grammar and update. * edit pass Edit pass on the final article. * Fix moved snippet links * Modify Sample This commit fixes #40796 * Apply suggestions from code review Co-authored-by: Genevieve Warren <[email protected]> * Clarify the create method Respond to feedback. The Create method must follow the same pattern used for collection expressions. --------- Co-authored-by: Genevieve Warren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc-enhancement
Improve the current content [org][type][category]
dotnet-csharp/svc
Pri3
📌 seQUESTered
Identifies that an issue has been imported into Quest.
whats-new/subsvc
Describe the issue or suggestion
I find the example for implicit index example to be confusing:
docs/docs/csharp/whats-new/csharp-13.md
Line 47 in 6ae8f61
The primary issue is that I have to guess what
v
andS
are. I realize that they are not important for the example, however, they are the first bits of code that I have to look at and parse. Also, is this code that one would ever write? Maybe this feature is just too niche to get this much fanfare?I like these pattern matching examples: https://learn.microsoft.com/dotnet/csharp/fundamentals/functional/pattern-matching.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
Associated WorkItem - 256379
The text was updated successfully, but these errors were encountered: