Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .NET SDK and .NET CLI telemetry about collecting data for mobile and WebAssembly workloads #39276

Open
ivanpovazan opened this issue Jan 26, 2024 · 5 comments · May be fixed by #40746
Open

Update .NET SDK and .NET CLI telemetry about collecting data for mobile and WebAssembly workloads #39276

ivanpovazan opened this issue Jan 26, 2024 · 5 comments · May be fixed by #40746
Assignees
@tdykstra
Labels
doc-enhancement Improve the current content [org][type][category] dotnet-fundamentals/svc in-pr This issue will be closed (fixed) by an active pull request. Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@ivanpovazan
Copy link
Member

ivanpovazan commented Jan 26, 2024 •
edited by sequestor bot

In .NET8, with dotnet/runtime#90208 we introduced telemetry for collecting data about mobile and WebAssembly workloads.

This change should also be documented in https://github.com/dotnet/docs/blob/e234edcaae55e45e93fbb4931a7ae70f16789f6d/docs/core/tools/telemetry.md by updating adequate tables in Data points section.

cc: @steveisok @vitek-karas @baronfel

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

Associated WorkItem - 251070
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jan 26, 2024
@ivanpovazan
Copy link
Member Author

I am not sure about setting the right labels, so please feel free to select the correct ones.

@tdykstra tdykstra self-assigned this May 1, 2024
@tdykstra tdykstra added doc-enhancement Improve the current content [org][type][category] 🗺️ reQUEST Triggers an issue to be imported into Quest. and removed ⌚ Not Triaged Not triaged Pri3 labels May 1, 2024
@tdykstra tdykstra mentioned this issue May 1, 2024
Merged
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels May 2, 2024
@timdeschryver
Copy link
Contributor

Hey @tdykstra you addressed me to this issue.

To be honest, I'm not exactly sure how to do this correctly. But, I tried my best with https://github.com/dotnet/docs/compare/main...timdeschryver:issue/39276?expand=1.
I wanted to ask you if I can create a PR for these changes because I'm not entirely confident if these changes are what's expected for this issue.

I also suppose the additional property added in dotnet/runtime#90950 needs to be documented.

@issues-automation issues-automation bot added dotnet-fundamentals/svc Pri1 High priority, do before Pri2 and Pri3 labels May 2, 2024
@tdykstra
Copy link
Contributor

tdykstra commented May 2, 2024

@ivanpovazan @steveisok I'm not sure how to translate the code in dotnet/runtime#90208 and dotnet/runtime#90950 to the table in the doc. @timdeschryver made a proposed update that you can see here. Is this correct? If not, can you please update a couple of data points in the table to show us how to interpret the code? And likewise if any data points from dotnet/runtime#90208 were missed in the proposed table changes.

@ivanpovazan
Copy link
Member Author

Hello, I would suggest opening a PR so it would be easier to review the changes and comment/align with what has been introduced in: dotnet/runtime#90208 and dotnet/runtime#90950

@timdeschryver timdeschryver linked a pull request May 3, 2024 that will close this issue
Open
@dotnet-policy-service dotnet-policy-service bot added the in-pr This issue will be closed (fixed) by an active pull request. label May 3, 2024
@timdeschryver
Copy link
Contributor

Sounds good!
I opened #40746 to track the changes, feedback is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdykstra tdykstra

Labels
doc-enhancement Improve the current content [org][type][category] dotnet-fundamentals/svc in-pr This issue will be closed (fixed) by an active pull request. Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add datapoints introduced in 8.0.100 timdeschryver/dotnet-docs
4 participants
@tdykstra @dotnet-bot @timdeschryver @ivanpovazan