Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Codecov CI step is silently failed from last week. #9853

Open
filzrev opened this issue Apr 9, 2024 · 1 comment
Open

[Bug] Codecov CI step is silently failed from last week. #9853

filzrev opened this issue Apr 9, 2024 · 1 comment
Labels
bug A bug to fix fundamental Engineering system and core components

Comments

@filzrev
Copy link
Contributor

filzrev commented Apr 9, 2024

Describe the bug

On GitHub Action CI.
It seems CodeCov step is silently failed from last week. (https://github.com/dotnet/docfx/actions/runs/8502861596)
with following warning.

test (ubuntu-latest)
Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov'
failed with exit code 1

Expected behavior

  • Codecov step is successfully completed.
  • CI error is reported as error if Codecov step is failed. (by enable additional fail_ci_if_error: true option)
@filzrev filzrev added the bug A bug to fix label Apr 9, 2024
@yufeih yufeih added the fundamental Engineering system and core components label Apr 10, 2024
@filzrev
Copy link
Contributor Author

filzrev commented May 14, 2024

It seems failed because codecov/codecov-action@v4 drop supports for token-less uploads.
codecov/feedback#315

It need set to repository secret and explicitly specify CODECOV_TOKEN.
And set fail_ci_if_error: true to stop CI.

https://github.com/dotnet/docfx/blob/main/.github/workflows/ci.yml#L46-L47

    - uses: codecov/codecov-action@v4
      if: matrix.os == 'ubuntu-latest'
      with:
        fail_ci_if_error: true
        token: ${{ secrets.CODECOV_TOKEN }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug to fix fundamental Engineering system and core components
Projects
None yet
Development

No branches or pull requests

2 participants