Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add a role='button' attribute to the theme selector drop down #9811

Open
ehakram opened this issue Mar 25, 2024 · 2 comments
Labels
static-site Produce static HTML output ready for publishing to hosts like GitHub pages

Comments

@ehakram
Copy link

ehakram commented Mar 25, 2024

Is your feature request related to a problem? Please describe.
When running docfx generated websites through PageSpeed Insights, I get the following: "[aria-] attributes do not match their roles."
For more context: https://dequeuniversity.com/rules/axe/4.7/aria-allowed-attr

Describe the solution you'd like
Probably: replace line 40 from docfx/templates/modern/src/theme.ts with the following:

Notice that role='button' was added.

Thank you.

@yufeih
Copy link
Contributor

yufeih commented Mar 25, 2024

Thank you @ehakram for reporting. Would you like to send a pull request?

@yufeih yufeih added the static-site Produce static HTML output ready for publishing to hosts like GitHub pages label Mar 25, 2024
@ehakram
Copy link
Author

ehakram commented Mar 25, 2024

I'd be happy to, but given my limited expertise in web development, setting up a local testing environment for my changes will require me a substantial amount of time. My apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
static-site Produce static HTML output ready for publishing to hosts like GitHub pages
Projects
None yet
Development

No branches or pull requests

2 participants