Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response compression for static assets to the dashboard #4153

Merged
merged 2 commits into from
May 17, 2024

Conversation

DamianEdwards
Copy link
Member

@DamianEdwards DamianEdwards commented May 10, 2024

Fixes #4150

Microsoft Reviewers: Open in CodeFlow

@DamianEdwards
Copy link
Member Author

@davidfowl @blowdart any comments on this one? It's pretty straightforward but there's nuance in where in the middleware pipeline it's enabled and enabling compression over HTTPS but not for HTML, to mitigate any security issues stemming from being able to force user content to be compressed over HTTPS.

@blowdart
Copy link

Funnily enough Javier is doing the same thing as a feature - you should sync with him for his new idea which might mitigate the need to do this in a custom manner. (But generally, no, no concerns for this type of thing as it's static assets)

@DamianEdwards
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DamianEdwards DamianEdwards merged commit 5f2af96 into main May 17, 2024
8 checks passed
@DamianEdwards DamianEdwards deleted the damianedwards/dashboard-response-compression branch May 17, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard should configure response compression & caching for static assets
5 participants