Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard should configure response compression & caching for static assets #4150

Closed
DamianEdwards opened this issue May 10, 2024 · 3 comments · Fixed by #4153
Closed

Dashboard should configure response compression & caching for static assets #4150

DamianEdwards opened this issue May 10, 2024 · 3 comments · Fixed by #4153
Assignees
@DamianEdwards
Labels
area-dashboard

Comments

@DamianEdwards
Copy link
Member

DamianEdwards commented May 10, 2024 •
edited

The dashboard currently doesn't configure compression or caching headers for the static assets it delivers, including libraries like plotly (which is 3.5 MB).

We should configure the response compression middleware to ensure that at least static assets are compressed (and potentially the HTML output too), and investigate setting cache headers for static assets with versioned paths to help improve the client-side experience.
@danmoseley
Copy link
Member

Just curious is this only noticeable in the case where the dashboard is on a different machine?

@DamianEdwards
Copy link
Member Author

Just curious is this only noticeable in the case where the dashboard is on a different machine?

From a UX perspective, most likely.

@DamianEdwards
Copy link
Member Author

TBC the dashboard is configuring the no-cache header for static assets, which forces the browser to honor the E-tag and/or Last-Modified headers sent, which usually results in 304 Not Modified responses for the static assets, so that's less of an issue than I originally thought.

DamianEdwards added a commit that referenced this issue May 10, 2024
@DamianEdwards
Add response compression for static assets to the dashboard
b7de211 
Fixes #4150
@DamianEdwards DamianEdwards mentioned this issue May 10, 2024
Merged
@DamianEdwards DamianEdwards self-assigned this May 10, 2024
@DamianEdwards DamianEdwards mentioned this issue May 10, 2024
Open
@JamesNK JamesNK mentioned this issue May 11, 2024
Open
DamianEdwards added a commit that referenced this issue May 17, 2024
@DamianEdwards
Add response compression for static assets to the dashboard (#4153)
5f2af96 
* Add response compression for static assets to the dashboard

Fixes #4150

* Use allow list for compressed MIME types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DamianEdwards DamianEdwards

Labels
area-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add response compression for static assets to the dashboard dotnet/aspire
2 participants
@DamianEdwards @danmoseley