Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WithPgAdmin does not use username parameter value when provided. #4100

Open
mitchdenny opened this issue May 7, 2024 · 0 comments · May be fixed by #4102
Open

WithPgAdmin does not use username parameter value when provided. #4100

mitchdenny opened this issue May 7, 2024 · 0 comments · May be fixed by #4102
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Milestone
8.1

Comments

@mitchdenny
Copy link
Member

mitchdenny commented May 7, 2024 •
edited

Currently the lifecycle hook that is registered via WithPgAdmin does not use the UserNameParameter and uses a hardcoded username of postgres. This means that if someone overrides the username it won't work.

aspire/src/Aspire.Hosting.PostgreSQL/PgAdminConfigWriterHook.cs

Line 40 in c6b9f8e

writer.WriteString("Username", "postgres");

@mitchdenny mitchdenny added this to the 8.1 milestone May 7, 2024
@mitchdenny mitchdenny linked a pull request May 7, 2024 that will close this issue
Open
@kvenkatrajan kvenkatrajan added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed area-dashboard labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
8.1
Development

Successfully merging a pull request may close this issue.

Make username parameter always be injected. dotnet/aspire
2 participants
@mitchdenny @kvenkatrajan